[webkit-reviews] review granted: [Bug 226497] REGRESSION(r277744): Broke build on s390x mainframes : [Attachment 430405] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 2 16:32:42 PDT 2021
Darin Adler <darin at apple.com> has granted Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 226497: REGRESSION(r277744): Broke build on s390x mainframes
https://bugs.webkit.org/show_bug.cgi?id=226497
Attachment 430405: Patch
https://bugs.webkit.org/attachment.cgi?id=430405&action=review
--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 430405
--> https://bugs.webkit.org/attachment.cgi?id=430405
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=430405&action=review
> Source/WTF/wtf/text/StringBuilder.cpp:31
> +#include <wtf/text/StringBuilderInternals.h>
>
> #include <wtf/dtoa.h>
Should probably be grouped in with the other includes below, not the special
"class header" paragraph.
> Source/WTF/wtf/text/StringBuilderJSON.cpp:16
> +#include <wtf/text/StringBuilderInternals.h>
>
> #include <wtf/text/WTFString.h>
Should probably be grouped in with the other includes below, not the special
"class header" paragraph.
More information about the webkit-reviews
mailing list