[webkit-reviews] review granted: [Bug 226420] B3MoveConstants should filter directly on Values, and only create ValueKeys when useful : [Attachment 430101] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 226420: B3MoveConstants should filter directly on Values, and only create
ValueKeys when useful
https://bugs.webkit.org/show_bug.cgi?id=226420

Attachment 430101: Patch

https://bugs.webkit.org/attachment.cgi?id=430101&action=review




--- Comment #4 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 430101
  --> https://bugs.webkit.org/attachment.cgi?id=430101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430101&action=review

r=me, though I recommend at least answering Mark's questions before landing.

>> Source/JavaScriptCore/b3/B3MoveConstants.cpp:331
>> +		return bitwise_cast<uint64_t>(constValue->value()) !=
bitwise_cast<uint64_t>(doubleZero);
> 
> Why the comparison of the bits?  Why not just do the double compare against
0.0?

Probably because -0 and +0 are equal?