[webkit-reviews] review granted: [Bug 226499] Hit-testing does not account for clip-path set on parent of <iframe> : [Attachment 430354] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 226499: Hit-testing does not account for clip-path set on parent of
<iframe>
https://bugs.webkit.org/show_bug.cgi?id=226499

Attachment 430354: Patch

https://bugs.webkit.org/attachment.cgi?id=430354&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 430354
  --> https://bugs.webkit.org/attachment.cgi?id=430354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430354&action=review

> Source/WebCore/rendering/RenderLayer.cpp:4114
> +    if (renderer().hasClipPath() &&
!downcast<RenderBox>(renderer()).hitTestClipPath(hitTestLocation,
toLayoutPoint(location() - renderBoxLocation())))

Are we sure that hitTestLocation is in the correct coordinate system for the
call to hitTestClipPath()?