[webkit-reviews] review granted: [Bug 226549] REGRESSION (r275227): Check boxes on V-Safe site flicker when selected : [Attachment 430389] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 226549: REGRESSION (r275227): Check boxes on V-Safe site flicker when
selected
https://bugs.webkit.org/show_bug.cgi?id=226549

Attachment 430389: Patch

https://bugs.webkit.org/attachment.cgi?id=430389&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 430389
  --> https://bugs.webkit.org/attachment.cgi?id=430389
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430389&action=review

> Source/WebCore/rendering/style/StyleCachedImage.cpp:60
> +    if (m_cssValue.ptr() == otherCached.m_cssValue.ptr() ||
m_cssValue->equals(otherCached.m_cssValue.get()))

Can this use arePointingToEqualData()?

> LayoutTests/webanimations/background-image-css-variable-no-transition.html:18
> +	   /* The bug fails to reproduce if the icon is not stored in a
variable. */
> +	   background-image: var(--checkbox-icon);
> +	   /* The bug fails to reproduce without a transition. */

Comments can be removed.

> LayoutTests/webanimations/background-image-css-variable-no-transition.html:32
> +    setTimeout(() => {
> +	   document.body.classList.add('changed');
> +	   shouldBe("document.getAnimations().length", "0");
> +    });

Did you intend to use the default timeout? Doesn't this need
waitUntilDone/notifyDone?