[webkit-reviews] review granted: [Bug 226010] [css-scroll-snap] Scroll snap is broken with non-horizontal writing modes : [Attachment 430329] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 226010: [css-scroll-snap] Scroll snap is broken with non-horizontal writing
modes
https://bugs.webkit.org/show_bug.cgi?id=226010

Attachment 430329: Patch

https://bugs.webkit.org/attachment.cgi?id=430329&action=review




--- Comment #13 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 430329
  --> https://bugs.webkit.org/attachment.cgi?id=430329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430329&action=review

> Source/WebCore/page/scrolling/ScrollSnapOffsetsInfo.cpp:241
> +    }

Maybe this whole block would be easier to read with just a switch
(scrollSnapType.axis)