[webkit-reviews] review granted: [Bug 226503] Fix inadvertent tag corruption in functionAddressOf : [Attachment 430302] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 16:09:30 PDT 2021


Darin Adler <darin at apple.com> has granted Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 226503: Fix inadvertent tag corruption in functionAddressOf
https://bugs.webkit.org/show_bug.cgi?id=226503

Attachment 430302: Patch

https://bugs.webkit.org/attachment.cgi?id=430302&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 430302
  --> https://bugs.webkit.org/attachment.cgi?id=430302
Patch

I suspect that other callers of reinterpret_cast<uint64_t> throughout WebKit
could have the same issue on 32-bit. There are 20 of them at least, and many
are likely converting from pointers to integers; the same fix would likely
apply.


More information about the webkit-reviews mailing list