[webkit-reviews] review granted: [Bug 226344] [run-webkit-tests] Move helper out of Port instance : [Attachment 430280] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 15:20:25 PDT 2021

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 226344: [run-webkit-tests] Move helper out of Port instance

Attachment 430280: Patch


--- Comment #7 from dewei_zhu at apple.com ---
Comment on attachment 430280
  --> https://bugs.webkit.org/attachment.cgi?id=430280

View in context: https://bugs.webkit.org/attachment.cgi?id=430280&action=review

r=me with comment.

> Tools/ChangeLog:12
> +	   (Port.stop_helper): All classes should share the same code to stop
the helper process.

Might worth mentioning we are doing this because popen object is not

More information about the webkit-reviews mailing list