[webkit-reviews] review granted: [Bug 225519] [Cocoa] _WKAuthenticatorAssertionResponse should specify the attachment type used : [Attachment 430291] Garrett's Patch with forward declaration.

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 225519: [Cocoa] _WKAuthenticatorAssertionResponse should specify the
attachment type used
https://bugs.webkit.org/show_bug.cgi?id=225519

Attachment 430291: Garrett's Patch with forward declaration.

https://bugs.webkit.org/attachment.cgi?id=430291&action=review




--- Comment #16 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 430291
  --> https://bugs.webkit.org/attachment.cgi?id=430291
Garrett's Patch with forward declaration.

View in context: https://bugs.webkit.org/attachment.cgi?id=430291&action=review

Thanks for fixing the API tests. r=me, but waiting for EWS to complete.

> Source/WebKit/WebAuthnProcess/WebAuthnConnectionToWebProcess.cpp:87
> +	       handler({ }, (AuthenticatorAttachment)0, exception);

This should be a C++ style cast. Or should we just be hard-coding it as
AuthenticatorAttachment::Platform?