[webkit-reviews] review granted: [Bug 226383] Adopt Reveal for phone numbers : [Attachment 430284] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dana Estra <destra at apple.com>'s
request for review:
Bug 226383: Adopt Reveal for phone numbers
https://bugs.webkit.org/show_bug.cgi?id=226383

Attachment 430284: Patch

https://bugs.webkit.org/attachment.cgi?id=430284&action=review




--- Comment #13 from Tim Horton <thorton at apple.com> ---
Comment on attachment 430284
  --> https://bugs.webkit.org/attachment.cgi?id=430284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430284&action=review

> Source/WebKit/Platform/mac/MenuUtilities.mm:121
> +    auto context = adoptNS([PAL::allocRVPresentingContextInstance()
initWithPointerLocationInView:NSZeroPoint inView:viewForPresenter.get()
highlightDelegate:delegate.get()]);

I wonder if we should ask Reveal folks (separately from this bug) for API that
doesn't take a view/point (or, if we do so and they tell us why that's a bad
idea, we'll understand why faking it like this is bad).