[webkit-reviews] review granted: [Bug 226328] MediaSession.coordinator should not be optional, relying on coordinator state change instead : [Attachment 430186] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 226328: MediaSession.coordinator should not be optional, relying on
coordinator state change instead
https://bugs.webkit.org/show_bug.cgi?id=226328

Attachment 430186: Patch

https://bugs.webkit.org/attachment.cgi?id=430186&action=review




--- Comment #20 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 430186
  --> https://bugs.webkit.org/attachment.cgi?id=430186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430186&action=review

> Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp:68
> +    if (privateCoordinator) {
> +	   setMediaSessionCoordinatorPrivate(*privateCoordinator);
> +    }

Nit: WebKit style is to omit braces on a single line condition.

> Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp:413
> +bool MediaSessionCoordinator::shouldFireEvents() const {

Nit: opening brace for a method should be on a new line.