[webkit-reviews] review granted: [Bug 226244] [WPE][GTK] Support building against uClibc : [Attachment 429702] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 226244: [WPE][GTK] Support building against uClibc
https://bugs.webkit.org/show_bug.cgi?id=226244

Attachment 429702: Patch

https://bugs.webkit.org/attachment.cgi?id=429702&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 429702
  --> https://bugs.webkit.org/attachment.cgi?id=429702
Patch

Unfortunately we're almost guaranteed to have unknown glibc-specific
assumptions that will result in incorrect behavior at runtime hidden throughout
WebKit. I guess the first step to finding them is to make it build.

E.g. one fun problem we used to have was gspawn relied on malloc being
async-signal-safe, so subprocess launching would randomly fail with other C
libraries , but only if you're sufficiently unlucky. That was eventually fixed
in fairly recent versions of glib. Point is: similar problems will be out
there....