[webkit-reviews] review granted: [Bug 226478] Fix thread safety issues in WaveShaperProcessor : [Attachment 430223] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226478: Fix thread safety issues in WaveShaperProcessor
https://bugs.webkit.org/show_bug.cgi?id=226478

Attachment 430223: Patch

https://bugs.webkit.org/attachment.cgi?id=430223&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 430223
  --> https://bugs.webkit.org/attachment.cgi?id=430223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430223&action=review

> Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:96
> +    for (size_t i = 0; i < m_kernels.size(); ++i)

auto?

> Source/WebCore/Modules/webaudio/WaveShaperProcessor.cpp:97
> +	  
static_cast<WaveShaperDSPKernel&>(*m_kernels[i]).process(source->channel(i)->da
ta(), destination->channel(i)->mutableData(), framesToProcess);

Why do we need static_cast<WaveShaperDSPKernel&> now while we did not in the
past?