[webkit-reviews] review granted: [Bug 226476] Fix thread safety issues in MediaStreamAudioSourceNode : [Attachment 430219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 04:57:49 PDT 2021


youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226476: Fix thread safety issues in MediaStreamAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=226476

Attachment 430219: Patch

https://bugs.webkit.org/attachment.cgi?id=430219&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 430219
  --> https://bugs.webkit.org/attachment.cgi?id=430219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430219&action=review

> Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp:109
> +    if (sourceSampleRate == sampleRate())

We could keep a single sampleRate call as a minor optimization.


More information about the webkit-reviews mailing list