[webkit-reviews] review granted: [Bug 227963] definePropertyOnReceiver should check if receiver canPerformFastPutInline : [Attachment 434676] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 17:34:50 PDT 2021

Alexey Shvayka <shvaikalesh at gmail.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 227963: definePropertyOnReceiver should check if receiver

Attachment 434676: Patch


--- Comment #25 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 434676
  --> https://bugs.webkit.org/attachment.cgi?id=434676

View in context: https://bugs.webkit.org/attachment.cgi?id=434676&action=review

Thank you for the fix! I've failed to see this case during review.
r=me with a comment.

> Source/JavaScriptCore/runtime/JSObject.cpp:939
> +	       if (entry->value->attributes() & PropertyAttribute::CustomValue)

I hope we would remove this in near feature as there is no use cases for
calling the setter except JSDollarVM.cpp.

> Source/JavaScriptCore/runtime/JSObject.cpp:942
> +		       RELEASE_AND_RETURN(scope, customSetter(globalObject,
JSValue::encode(this), JSValue::encode(value), propertyName));

For consistency: `... customSetter(structure->globalObject(), ...`

More information about the webkit-reviews mailing list