[webkit-reviews] review granted: [Bug 198230] [css-overflow] Implement clip value for overflow : [Attachment 434612] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 198230: [css-overflow] Implement clip value for overflow
https://bugs.webkit.org/show_bug.cgi?id=198230

Attachment 434612: Patch

https://bugs.webkit.org/attachment.cgi?id=434612&action=review




--- Comment #32 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434612
  --> https://bugs.webkit.org/attachment.cgi?id=434612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434612&action=review

So where do we actually reap the performance rewards from overflow:clip?

> Source/WebCore/style/StyleAdjuster.cpp:425
> +    if (style.overflowY() != Overflow::Visible && style.overflowY() !=
Overflow::Clip) {

I think the lambda could also include this test