[webkit-reviews] review granted: [Bug 228631] RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount : [Attachment 434609] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 08:32:15 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 228631: RemoteAudioMediaStreamTrackRendererInternalUnit should handle
changes of requested sampleCount
https://bugs.webkit.org/show_bug.cgi?id=228631

Attachment 434609: Patch

https://bugs.webkit.org/attachment.cgi?id=434609&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 434609
  --> https://bugs.webkit.org/attachment.cgi?id=434609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434609&action=review

>
Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnit
Manager.cpp:182
> +    uint64_t requestedSamplesCount = m_generateOffset;

Nit: could be `auto`


More information about the webkit-reviews mailing list