[webkit-reviews] review granted: [Bug 228634] AVVideoCaptureSource should not start/stop the camera if trying to apply the same size/frame rate configuration : [Attachment 434613] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 08:25:49 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 228634: AVVideoCaptureSource should not start/stop the camera if trying to
apply the same size/frame rate configuration
https://bugs.webkit.org/show_bug.cgi?id=228634

Attachment 434613: Patch

https://bugs.webkit.org/attachment.cgi?id=434613&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 434613
  --> https://bugs.webkit.org/attachment.cgi?id=434613
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434613&action=review

> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:333
> +	   ALWAYS_LOG_IF(loggerPtr(), LOGIDENTIFIER, " settings already
matching");

s/matching/match/


More information about the webkit-reviews mailing list