[webkit-reviews] review granted: [Bug 228641] Attribute nw connections to the source application : [Attachment 434625] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted  review:
Bug 228641: Attribute nw connections to the source application
https://bugs.webkit.org/show_bug.cgi?id=228641

Attachment 434625: Patch

https://bugs.webkit.org/attachment.cgi?id=434625&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 434625
  --> https://bugs.webkit.org/attachment.cgi?id=434625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434625&action=review

We also set configuration.get()._attributedBundleIdentifier for
SafariViewController based on the page ID.

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:100
> +	   nw_parameters_set_source_application(tcpTLS.get(),
*reinterpret_cast<const
audit_token_t*>(CFDataGetBytePtr(sourceApplicationAuditData)));

RELEASE_ASSERT(CFDataGetSize(sourceApplicationAuditData) ==
sizeof(audit_token_t));

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:239
> +	   nw_parameters_set_source_application(parameters,
*reinterpret_cast<const
audit_token_t*>(CFDataGetBytePtr(m_sourceApplicationAuditData.get())));

ditto