[webkit-reviews] review requested: [Bug 228140] [WebAudio] webm; properly trim frames according to the codec delay information : [Attachment 434614] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 30 03:31:43 PDT 2021


Jean-Yves Avenard [:jya] <jean-yves.avenard at apple.com> has asked  for review:
Bug 228140: [WebAudio] webm; properly trim frames according to the codec delay
information
https://bugs.webkit.org/show_bug.cgi?id=228140

Attachment 434614: Patch

https://bugs.webkit.org/attachment.cgi?id=434614&action=review




--- Comment #3 from Jean-Yves Avenard [:jya] <jean-yves.avenard at apple.com> ---
Created attachment 434614

  --> https://bugs.webkit.org/attachment.cgi?id=434614&action=review

Patch

For the proper amount of frames to be returned, we need to explicitly tell the
AudioConverter that we've reached EOS; this is done by returning noErr and set
the number of decoded frames to 0


More information about the webkit-reviews mailing list