[webkit-reviews] review granted: [Bug 228633] [Media Controls] Add an option for having no scrubber on the time control and parameterize margin : [Attachment 434611] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 228633: [Media Controls] Add an option for having no scrubber on the time
control and parameterize margin
https://bugs.webkit.org/show_bug.cgi?id=228633

Attachment 434611: Patch

https://bugs.webkit.org/attachment.cgi?id=434611&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434611
  --> https://bugs.webkit.org/attachment.cgi?id=434611
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434611&action=review

> Source/WebCore/Modules/modern-media-controls/controls/slider.js:147
> +	       if (style === Slider.KnobStyle.Bar)

Normally I would say "use `case` so you force people adding new styles to come
back here and make a decision", but JavaScript is all loosey goosey so it
doesn't really matter?

> Source/WebCore/Modules/modern-media-controls/controls/slider.js:225
> +    None: "none"

maintain the trailing comma? :D