[webkit-reviews] review granted: [Bug 228179] [Cocoa] Stop building WebGPU and the WHLSL compiler to decrease binary size : [Attachment 434588] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 228179: [Cocoa] Stop building WebGPU and the WHLSL compiler to decrease
binary size
https://bugs.webkit.org/show_bug.cgi?id=228179

Attachment 434588: Patch

https://bugs.webkit.org/attachment.cgi?id=434588&action=review




--- Comment #25 from Dean Jackson <dino at apple.com> ---
Comment on attachment 434588
  --> https://bugs.webkit.org/attachment.cgi?id=434588
Patch

Can you mention in the change log that this isn't because we don't want to
support WebGPU, but rather that this implementation is incorrect and not
serving any purpose (other than slowing down the build). We'll implement a
better version.

Also, you say this is for Cocoa, but also remove the Dawn code that was added
by other contributors. I guess this makes sense since you're removing the
feature.