[webkit-reviews] review granted: [Bug 228571] [ Mac ] fast/dom/webtiming-document-open.html is a flaky failure : [Attachment 434532] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 228571: [ Mac ] fast/dom/webtiming-document-open.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=228571

Attachment 434532: Patch

https://bugs.webkit.org/attachment.cgi?id=434532&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 434532
  --> https://bugs.webkit.org/attachment.cgi?id=434532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434532&action=review

> Source/WebCore/page/PerformanceTiming.cpp:58
>	   return 0;

Is it intentional in all these getters that we're not caching in early return
cases?

> Source/WebCore/page/PerformanceTiming.cpp:80
> +    m_unloadEventStart = 
monotonicTimeToIntegerMilliseconds(timing->unloadEventStart());

nit: extra space