[webkit-reviews] review granted: [Bug 228116] REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers : [Attachment 434440] Patch

[bugzilla-daemon at webkit.org]

Per Arne Vollan <pvollan at apple.com> has granted Kate Cheney
<katherine_cheney at apple.com>'s request for review:
Bug 228116: REGRESSION (r278877) [Cocoa] WebAuthn stopped working for
non-Safari browsers
https://bugs.webkit.org/show_bug.cgi?id=228116

Attachment 434440: Patch

https://bugs.webkit.org/attachment.cgi?id=434440&action=review




--- Comment #20 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 434440
  --> https://bugs.webkit.org/attachment.cgi?id=434440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434440&action=review

R=me.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:6
> +	objectVersion = 54;

Is this an intended change?

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-6003
> -		F414CE2A269DDED100BD216A /* GPUProcessCocoa.mm */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp;
name = GPUProcessCocoa.mm; path = cocoa/GPUProcessCocoa.mm; sourceTree =
"<group>"; };

Ditto.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:-11726
> -		F414CE27269DDE8000BD216A /* cocoa */ = {
> -			isa = PBXGroup;
> -			children = (
> -				F414CE2A269DDED100BD216A /* GPUProcessCocoa.mm
*/,
> -			);
> -			name = cocoa;
> -			sourceTree = "<group>";
> -		};

Ditto.