[webkit-reviews] review granted: [Bug 228027] [git-webkit] Add identifiers to 'log' and 'blame' : [Attachment 434522] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 10:14:57 PDT 2021


dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 228027: [git-webkit] Add identifiers to 'log' and 'blame'
https://bugs.webkit.org/show_bug.cgi?id=228027

Attachment 434522: Patch

https://bugs.webkit.org/attachment.cgi?id=434522&action=review




--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 434522
  --> https://bugs.webkit.org/attachment.cgi?id=434522
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434522&action=review

r=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/blame.py:37
> +	   return Blame.pager(args, repository, file=__file__, **kwargs)

Is It intentional to use 'Blame.pager' rather than 'cls.pager' ?

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py:37
> +	   return Log.pager(args, repository, file=__file__, **kwargs)

Ditto.


More information about the webkit-reviews mailing list