[webkit-reviews] review granted: [Bug 228574] makeWeakPtr should support Ref and RefPtr as the argument : [Attachment 434475] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 16:56:25 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 228574: makeWeakPtr should support Ref and RefPtr as the argument
https://bugs.webkit.org/show_bug.cgi?id=228574

Attachment 434475: Patch

https://bugs.webkit.org/attachment.cgi?id=434475&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 434475
  --> https://bugs.webkit.org/attachment.cgi?id=434475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434475&action=review

r=mews

> Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:370
> +    Ref baseObject = BaseObjectWithRefAndWeakPtr::create();

Nit - auto?


More information about the webkit-reviews mailing list