[webkit-reviews] review granted: [Bug 228560] [Cocoa] Remove support for AVAssetImageGenerator : [Attachment 434467] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 228560: [Cocoa] Remove support for AVAssetImageGenerator
https://bugs.webkit.org/show_bug.cgi?id=228560

Attachment 434467: Patch

https://bugs.webkit.org/attachment.cgi?id=434467&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 434467
  --> https://bugs.webkit.org/attachment.cgi?id=434467
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434467&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:2387
> +    if ([m_videoOutput
respondsToSelector:@selector(requestNotificationOfMediaDataChangeAsSoonAsPossib
le)])
> +	   [m_videoOutput
requestNotificationOfMediaDataChangeAsSoonAsPossible];

As discussed, it might be worth logging an error if it doesn't support this
selector