[webkit-reviews] review granted: [Bug 228155] macOS key-driven smooth scrolling does not work for spacebar : [Attachment 434226] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted  review:
Bug 228155: macOS key-driven smooth scrolling does not work for spacebar
https://bugs.webkit.org/show_bug.cgi?id=228155

Attachment 434226: Patch

https://bugs.webkit.org/attachment.cgi?id=434226&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434226
  --> https://bugs.webkit.org/attachment.cgi?id=434226
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review

>> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237
>> +	if (!(event.type() == eventNames().keydownEvent || event.type() ==
eventNames().keypressEvent))
> 
> Hmm, I'm not sure this is right. Are you not getting `keydown` for the
spacebar? If not, you probably want to figure out who is eating it.

I guess it's OK (a bit weird, but existing weirdness);
EventHandler::defaultSpaceEventHandler itself asserts it's only called with
keypress, and the other callers of this call it explicitly only for keydown, so
we won't get duplicates.