[webkit-reviews] review granted: [Bug 228549] RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle : [Attachment 434420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 28 07:01:39 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 228549: RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update
m_currentRotationSessionAngle
https://bugs.webkit.org/show_bug.cgi?id=228549

Attachment 434420: Patch

https://bugs.webkit.org/attachment.cgi?id=434420&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 434420
  --> https://bugs.webkit.org/attachment.cgi?id=434420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434420&action=review

>
Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:78
> +	   IntSize size = { (int)pixelWidth , (int)pixelHeight };

Nit: the local isn't strictly necessary.


More information about the webkit-reviews mailing list