[webkit-reviews] review granted: [Bug 228290] [WPE][GTK] SVN_REVISION drifting away if bots don't re-run cmake : [Attachment 434422] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 228290: [WPE][GTK] SVN_REVISION drifting away if bots don't re-run cmake
https://bugs.webkit.org/show_bug.cgi?id=228290

Attachment 434422: Patch

https://bugs.webkit.org/attachment.cgi?id=434422&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 434422
  --> https://bugs.webkit.org/attachment.cgi?id=434422
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434422&action=review

> Source/cmake/OptionsCommon.cmake:172
> +if (PORT STREQUAL "GTK" OR PORT STREQUAL "WPE")

Nit: I would move this to OptionsGTK.cmake and OptionsWPE.cmake to try to keep
this file as port-agnostic as possible.