[webkit-reviews] review granted: [Bug 228310] [Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed : [Attachment 434260] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 228310: [Modern Media Controls] [macOS] Overflow button still shows as `on`
even after contextmenu is dismissed
https://bugs.webkit.org/show_bug.cgi?id=228310

Attachment 434260: Patch

https://bugs.webkit.org/attachment.cgi?id=434260&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 434260
  --> https://bugs.webkit.org/attachment.cgi?id=434260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434260&action=review

> Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:71
> +    m_page->shouldWaitForContextMenuToShow();

Nit - `shouldWaitForContextMenuToShow()` sounds a bit like the name of a const
getter. Perhaps something along the lines of
`startWaitingForContextMenuToShow()`?