[webkit-reviews] review requested: [Bug 228038] REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener() : [Attachment 434240] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 228038: REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount
under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener()
https://bugs.webkit.org/show_bug.cgi?id=228038

Attachment 434240: Patch

https://bugs.webkit.org/attachment.cgi?id=434240&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 434240
  --> https://bugs.webkit.org/attachment.cgi?id=434240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434240&action=review

> Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp:69
> +	  
m_gpuProcessConnection->messageReceiverMap().removeMessageReceiver(*this);

Don't we want to null out m_gpuProcessConnection too to make sure that the
RemoteAudioHardwareListener destructor doesn't attempt to do the same thing if
the GPUProcessConnection is still alive? I think it would likely hit assertions
if we called messageReceiverMap().removeMessageReceiver(*this) unnecessarily.