[webkit-reviews] review granted: [Bug 227791] [GPU Process] Regulate the WebPage RenderingUpdates from the WebProcess to the GPUProcess : [Attachment 434227] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 227791: [GPU Process] Regulate the WebPage RenderingUpdates from the
WebProcess to the GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=227791

Attachment 434227: Patch

https://bugs.webkit.org/attachment.cgi?id=434227&action=review




--- Comment #19 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434227
  --> https://bugs.webkit.org/attachment.cgi?id=434227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434227&action=review

> Source/WebCore/ChangeLog:12
> +	   certain number of rescheduling.

reschedules

> Source/WebKit/Shared/MonotonicObjectIdentifier.h:129
> +template<typename T>
> +inline unsigned operator-(const MonotonicObjectIdentifier<T>& a, const
MonotonicObjectIdentifier<T>& b)
> +{
> +    return a.toUInt64() - b.toUInt64();
> +}

I think this needs to return a signed Int64 value to avoid mistakes.

> Source/WebKit/WebProcess/WebPage/WebPage.h:402
> +    bool canTriggerRenderingUpdate(unsigned rescheduledRenderingUpdateCount)
const;

canTriggerRenderingUpdate -> shouldTriggerRenderingUpdate