[webkit-reviews] review granted: [Bug 228295] Rename activeWindow to incumbentWindow in the Location class : [Attachment 434229] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228295: Rename activeWindow to incumbentWindow in the Location class
https://bugs.webkit.org/show_bug.cgi?id=228295

Attachment 434229: Patch

https://bugs.webkit.org/attachment.cgi?id=434229&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 434229
  --> https://bugs.webkit.org/attachment.cgi?id=434229
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434229&action=review

> Source/WebCore/page/Location.cpp:284
>      URL completedURL = firstFrame->document()->completeURL(urlString);
> +
> +
>      // FIXME: The specification says to throw a SyntaxError if the URL is
not valid.

Not sure why there are two blank lines here.