[webkit-reviews] review denied: [Bug 228155] macOS key-driven smooth scrolling does not work for spacebar : [Attachment 434226] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 26 13:05:18 PDT 2021
Tim Horton <thorton at apple.com> has denied Dana Estra <destra at apple.com>'s
request for review:
Bug 228155: macOS key-driven smooth scrolling does not work for spacebar
https://bugs.webkit.org/show_bug.cgi?id=228155
Attachment 434226: Patch
https://bugs.webkit.org/attachment.cgi?id=434226&action=review
--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434226
--> https://bugs.webkit.org/attachment.cgi?id=434226
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review
> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237
> - if (event.type() != eventNames().keydownEvent)
> + if (!(event.type() == eventNames().keydownEvent || event.type() ==
eventNames().keypressEvent))
Hmm, I'm not sure this is right. Are you not getting `keydown` for the
spacebar? If not, you probably want to figure out who is eating it.
More information about the webkit-reviews
mailing list