[webkit-reviews] review granted: [Bug 228239] [Cocoa] Playback stalls on bilibili.com : [Attachment 434107] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 26 10:31:11 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 228239: [Cocoa] Playback stalls on bilibili.com
https://bugs.webkit.org/show_bug.cgi?id=228239

Attachment 434107: Patch

https://bugs.webkit.org/attachment.cgi?id=434107&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 434107
  --> https://bugs.webkit.org/attachment.cgi?id=434107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434107&action=review

> Source/WebCore/ChangeLog:18
> +	   To make the call less ambiguous, add a MediaPlayer and
MediaPlayerPrivate effectiveRate

Nit: you should pull the "()" back to the previous line


More information about the webkit-reviews mailing list