[webkit-reviews] review granted: [Bug 227718] Add support for FormDataEvent : [Attachment 434149] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Qiaosong Zhou
<qiaosong_zhou at apple.com>'s request for review:
Bug 227718: Add support for FormDataEvent
https://bugs.webkit.org/show_bug.cgi?id=227718

Attachment 434149: Patch

https://bugs.webkit.org/attachment.cgi?id=434149&action=review




--- Comment #63 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 434149
  --> https://bugs.webkit.org/attachment.cgi?id=434149
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434149&action=review

r=me with one comment.

> Source/WebCore/platform/network/FormData.cpp:278
> +	   if (!WTF::holds_alternative<String>(item.data))

Is this really still needed? I thought my proposal to do `newFormData->m_items
= m_items;` would avoid this.