[webkit-reviews] review granted: [Bug 228240] 3.5 MB system-wide footprint impact due to thread-locals in libANGLE : [Attachment 434148] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 228240: 3.5 MB system-wide footprint impact due to thread-locals in
libANGLE
https://bugs.webkit.org/show_bug.cgi?id=228240

Attachment 434148: Patch

https://bugs.webkit.org/attachment.cgi?id=434148&action=review




--- Comment #8 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 434148
  --> https://bugs.webkit.org/attachment.cgi?id=434148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434148&action=review

This revision looks better to me. Since Geoff had concerns earlier, please sync
up with him too. r+ with two small nits.

> Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp:297
> +TLSIndex CurrentValidContextIndex = TLS_INVALID_INDEX;

Nit: did you want to put this in an anonymous namespace, make it static, etc.
to hide the symbol's visibility?

> Source/ThirdParty/ANGLE/src/libGLESv2/global_state.cpp:94
> +TLSIndex CurrentThreadIndex = TLS_INVALID_INDEX;

Same question here.