[webkit-reviews] review granted: [Bug 228161] SharedBuffer::takeData() is a bit dangerous : [Attachment 433959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 23 12:32:13 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 228161: SharedBuffer::takeData() is a bit dangerous

Attachment 433959: Patch


--- Comment #18 from Darin Adler <darin at apple.com> ---
Comment on attachment 433959
  --> https://bugs.webkit.org/attachment.cgi?id=433959

Should we do both? Still have the takeData overload for && but have extractData
as syntactic sugar so it’s easier to call correctly. Seems like a way to "dip
our toes in the water" of the && functions and maybe try to make move(x).take
the future idiom.

More information about the webkit-reviews mailing list