[webkit-reviews] review requested: [Bug 228240] 3.5 MB system-wide footprint impact due to thread-locals in libANGLE : [Attachment 434103] WIP

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has asked  for review:
Bug 228240: 3.5 MB system-wide footprint impact due to thread-locals in
libANGLE
https://bugs.webkit.org/show_bug.cgi?id=228240

Attachment 434103: WIP

https://bugs.webkit.org/attachment.cgi?id=434103&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Created attachment 434103

  --> https://bugs.webkit.org/attachment.cgi?id=434103&action=review

WIP

Work in progress to get review. Please ignore the change to WebKit networking
code - that was to help a local compile.

I'm not confident in this patch because:
- I've never used pthread_key_create before
- I'm worried about a performance regression in querying state on every access
(which happens a lot)
- I want a better place to initialise and delete the keys
- This is an invasive patch that will need to be applied each time we update
ANGLE

Eventually we'll fix dyld's thread_local implementation.