[webkit-reviews] review granted: [Bug 228116] REGRESSION (r278877) [Cocoa] WebAuthn stopped working for non-Safari browsers : [Attachment 433974] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 15:05:06 PDT 2021

Per Arne Vollan <pvollan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 228116: REGRESSION (r278877) [Cocoa] WebAuthn stopped working for
non-Safari browsers

Attachment 433974: Patch


--- Comment #8 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 433974
  --> https://bugs.webkit.org/attachment.cgi?id=433974

View in context: https://bugs.webkit.org/attachment.cgi?id=433974&action=review


>> Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:56
>> +		    auto [signingIdentifier, isPlatformBinary] =
> @Per Arne: Do you think we should enable this check on all platforms (not
just macOS)?

Yes, I think that would be good. I am not sure why that was not done initially.
If changing, you might need to test manually that this behaves correctly on

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:318
>      auto auditToken = connection()->getAuditToken();
>      if (!auditToken) {

Can this be removed now?

> Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:327
> +    if (!currentProcessIsPlatformBinary())
> +	   return true;

Should this return false? Or should it be 'return
currentProcessIsPlatformBinary()' to avoid executing the code below?

More information about the webkit-reviews mailing list