[webkit-reviews] review granted: [Bug 228193] AirStackSlot's uint16_t byte size is too small : [Attachment 434030] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 13:30:55 PDT 2021


Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 228193: AirStackSlot's uint16_t byte size is too small
https://bugs.webkit.org/show_bug.cgi?id=228193

Attachment 434030: patch

https://bugs.webkit.org/attachment.cgi?id=434030&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 434030
  --> https://bugs.webkit.org/attachment.cgi?id=434030
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434030&action=review

r=me

> Source/JavaScriptCore/b3/B3Procedure.cpp:76
> +Air::StackSlot* Procedure::addStackSlot(uint64_t byteSize)

Let's use size_t instead of uint64_t in all these size values.


More information about the webkit-reviews mailing list