[webkit-reviews] review granted: [Bug 228018] [Cocoa] ".SF Arabic" should not be able to be looked up by name (because it is dot-prefixed) : [Attachment 433975] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 228018: [Cocoa] ".SF Arabic" should not be able to be looked up by name
(because it is dot-prefixed)
https://bugs.webkit.org/show_bug.cgi?id=228018

Attachment 433975: Patch

https://bugs.webkit.org/attachment.cgi?id=433975&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 433975
  --> https://bugs.webkit.org/attachment.cgi?id=433975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433975&action=review

Is it OK to do this on all OS versions?

> Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:1114
> +	   || equalLettersIgnoringASCIICase(family, ".sf arabic")) {

I would move this up to below ".sf ui mono"