[webkit-reviews] review granted: [Bug 228181] REGRESSION (r279992): Crashes under RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst : [Attachment 434002] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 228181: REGRESSION (r279992): Crashes under
RemoteLayerBackingStore::applyBackingStoreToLayer() in macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=228181

Attachment 434002: Patch

https://bugs.webkit.org/attachment.cgi?id=434002&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 434002
  --> https://bugs.webkit.org/attachment.cgi?id=434002
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434002&action=review

Patch looks good.

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:429
> +    RetainPtr<id> contents = nil;

OK as-is. No change needed. Thoughts about removing the = nil and letting the
default constructor initialize this?