[webkit-reviews] review granted: [Bug 228170] XHR.send(Document) should replace mismatched surrogates with replacement character before sending : [Attachment 433987] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 228170: XHR.send(Document) should replace mismatched surrogates with
replacement character before sending
https://bugs.webkit.org/show_bug.cgi?id=228170

Attachment 433987: Patch

https://bugs.webkit.org/attachment.cgi?id=433987&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433987
  --> https://bugs.webkit.org/attachment.cgi?id=433987
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433987&action=review

> Source/WebCore/xml/XMLHttpRequest.cpp:487
> +	   auto converted = stringToUSVString(WTFMove(serialized));

Would have been nice to rename stringToUSVString() to
replaceUnpairedSurrogatesWithReplacementCharacter() since you are reusing it
here for something that is not strictly a USVString conversion.