[webkit-reviews] review granted: [Bug 228172] Avoid Quick Note overlay when scrolling to show a highlight : [Attachment 434010] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 08:07:13 PDT 2021


Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 228172: Avoid Quick Note overlay when scrolling to show a highlight
https://bugs.webkit.org/show_bug.cgi?id=228172

Attachment 434010: Patch

https://bugs.webkit.org/attachment.cgi?id=434010&action=review




--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 434010
  --> https://bugs.webkit.org/attachment.cgi?id=434010
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434010&action=review

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1162
> +    if (CGRectIsNull(CGRectNull))

You should probably use the `overlayRect` here.


More information about the webkit-reviews mailing list