[webkit-reviews] review granted: [Bug 228172] Avoid Quick Note overlay when scrolling to show a highlight : [Attachment 433992] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 21 23:01:40 PDT 2021
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 228172: Avoid Quick Note overlay when scrolling to show a highlight
https://bugs.webkit.org/show_bug.cgi?id=228172
Attachment 433992: Patch
https://bugs.webkit.org/attachment.cgi?id=433992&action=review
--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 433992
--> https://bugs.webkit.org/attachment.cgi?id=433992
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=433992&action=review
stylebot complaint is /mystifying/
> Source/WebCore/ChangeLog:3
> + Avoid Quick Note overlay when scrolling to show a highlight
This seems straightforwardly API-testable (swizzle the Synapse observer,
restore+scroll, see where you end up), you should write some tests.
> Source/WebCore/editing/FrameSelection.cpp:2334
> + auto visibleSelectionRect = IntRect();
This is a funny way to write `IntRect visibleSelectionRect;`
> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1173
> + float midScreen = [self center].y;
dots!
More information about the webkit-reviews
mailing list