[webkit-reviews] review denied: [Bug 172044] [macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout. : [Attachment 433962] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 172044: [macOS Debug] Layout Test
imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky
timeout.
https://bugs.webkit.org/show_bug.cgi?id=172044

Attachment 433962: Patch

https://bugs.webkit.org/attachment.cgi?id=433962&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433962
  --> https://bugs.webkit.org/attachment.cgi?id=433962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433962&action=review

The code change looks acceptable but landing FAIL baselines for tests is not.

>
LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-exp
ected.txt:29
> +FAIL sawVersionChange should be true. Was false.

Since those are WebKit tests (not WPT), please fix those tests to reflect the
new behavior instead of landing failure expectations.