[webkit-reviews] review granted: [Bug 228134] Crash in -[WKWebView takeSnapshotWithConfiguration:completionHandler:] when taking empty snapshots : [Attachment 433914] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 21 08:28:33 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 228134: Crash in -[WKWebView
takeSnapshotWithConfiguration:completionHandler:] when taking empty snapshots
https://bugs.webkit.org/show_bug.cgi?id=228134

Attachment 433914: Patch

https://bugs.webkit.org/attachment.cgi?id=433914&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 433914
  --> https://bugs.webkit.org/attachment.cgi?id=433914
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433914&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1179
> +	   RunLoop::main().dispatch([handler] {

handler = WTFMove(handler) to avoid refcounting churn.


More information about the webkit-reviews mailing list