[webkit-reviews] review denied: [Bug 228090] Migrate Monterey expectations to OpenSource : [Attachment 433908] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 20 16:59:25 PDT 2021


Ryan Haddad <ryanhaddad at apple.com> has denied Truitt Savell
<tsavell at apple.com>'s request for review:
Bug 228090: Migrate Monterey expectations to OpenSource
https://bugs.webkit.org/show_bug.cgi?id=228090

Attachment 433908: Patch

https://bugs.webkit.org/attachment.cgi?id=433908&action=review




--- Comment #5 from Ryan Haddad <ryanhaddad at apple.com> ---
Comment on attachment 433908
  --> https://bugs.webkit.org/attachment.cgi?id=433908
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433908&action=review

> Tools/Scripts/webkitpy/port/mac.py:51
> +    LAST_MACOSX = Version(11, 0)

LAST_MACOSX should be left as (10, 15)

> Tools/Scripts/webkitpy/port/mac_unittest.py:205
>	   search_path =
self.make_port(port_name='macos-big-sur').default_baseline_search_path()

port_name='macos-big-sur' -> port_name='macos-monterey'


More information about the webkit-reviews mailing list