[webkit-reviews] review granted: [Bug 228099] Use references instead of pointers in WidthIterator::advanceInternal() : [Attachment 433852] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 20 13:23:30 PDT 2021


Fujii Hironori <Hironori.Fujii at sony.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 228099: Use references instead of pointers in
WidthIterator::advanceInternal()
https://bugs.webkit.org/show_bug.cgi?id=228099

Attachment 433852: Patch

https://bugs.webkit.org/attachment.cgi?id=433852&action=review




--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 433852
  --> https://bugs.webkit.org/attachment.cgi?id=433852
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433852&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:237
> +	   ASSERT(&font);

This ASSERT doesn't looks useful. I think you should remove this ASSERT.


More information about the webkit-reviews mailing list